[
https://issues.apache.org/jira/browse/BEAM-13488?focusedWorklogId=702161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-702161
]
ASF GitHub Bot logged work on BEAM-13488:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Dec/21 00:39
Start Date: 30/Dec/21 00:39
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #16275:
URL: https://github.com/apache/beam/pull/16275#discussion_r776533959
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/resources/ClasspathScanningResourcesDetector.java
##########
@@ -45,7 +45,11 @@ public ClasspathScanningResourcesDetector(ClassGraph
classGraph) {
@Override
public List<String> detect(ClassLoader classLoader) {
List<File> classpathContents =
-
classGraph.disableNestedJarScanning().addClassLoader(classLoader).getClasspathFiles();
+ classGraph
+ .disableNestedJarScanning()
+ .addClassLoader(classLoader)
+ .scan(1)
Review comment:
@steveniemitz Please follow up with a separate PR if this is not
addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 702161)
Time Spent: 1h 20m (was: 1h 10m)
> ClassGraph scanner is nondeterministic/incomplete when using parallel scans
> ---------------------------------------------------------------------------
>
> Key: BEAM-13488
> URL: https://issues.apache.org/jira/browse/BEAM-13488
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> See [https://github.com/classgraph/classgraph/issues/614]
> In certain cases parallel scans with classgraph will return only some of the
> classpath. Until this bug is fixed, we can work around it by setting
> parallelism = 1 when doing the scan. In practice there's no performance
> difference between 1 vs the default, even for very large classpaths.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
