[
https://issues.apache.org/jira/browse/BEAM-6876?focusedWorklogId=219452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219452
]
ASF GitHub Bot logged work on BEAM-6876:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/19 17:19
Start Date: 27/Mar/19 17:19
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8118: [BEAM-6876]
Cleanup user state in portable Flink Runner
URL: https://github.com/apache/beam/pull/8118#discussion_r269678900
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -351,25 +341,26 @@ private void prepareStateBackend(K key, Coder<K>
keyCoder) {
}
}
+ /**
+ * Note: This is only relevant when we have a stateful DoFn. We want to
control the key of the
+ * state backend ourselves and we must avoid any concurrent setting of the
current active key. By
+ * overwriting this, we also prevent unnecessary serialization as the key
has to be encoded as a
+ * byte array.
+ */
@Override
- public void setKeyContextElement1(StreamRecord record) throws Exception {
- // Note: This is only relevant when we have a stateful DoFn.
- // We want to control the key of the state backend ourselves and
- // we must avoid any concurrent setting of the current active key.
- // By overwriting this, we also prevent unnecessary serialization
- // as the key has to be encoded as a byte array.
- }
-
+ public void setKeyContextElement1(StreamRecord record) {}
+
+ /**
+ * We don't to set anything here. This is due to asynchronous nature of
processing elements from
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 219452)
Time Spent: 2h 10m (was: 2h)
> User state cleanup in portable Flink runner
> -------------------------------------------
>
> Key: BEAM-6876
> URL: https://issues.apache.org/jira/browse/BEAM-6876
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.11.0
> Reporter: Thomas Weise
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability-flink
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> State is currently not being cleaned up by the runner.
> [https://lists.apache.org/thread.html/86f0809fbfa3da873051287b9ff249d6dd5a896b45409db1e484cf38@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
