[
https://issues.apache.org/jira/browse/BEAM-13399?focusedWorklogId=708003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708003
]
ASF GitHub Bot logged work on BEAM-13399:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/22 01:48
Start Date: 13/Jan/22 01:48
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #16487:
URL: https://github.com/apache/beam/pull/16487#discussion_r783565635
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go
##########
@@ -60,11 +63,24 @@ func (e *ExpansionServiceRunner) String() string {
}
// Endpoint returns the formatted endpoint the ExpansionServiceRunner is set
to start the expansion
-// service on.
+// service on.
func (e *ExpansionServiceRunner) Endpoint() string {
return "localhost:" + e.servicePort
}
+func (e *ExpansionServiceRunner) pingEndpoint(timeout time.Duration) error {
Review comment:
Notionally this will mean things take a bit longer since we're
connecting twice (here, and actual use), but It's probably fine until we
determine if it's problematic or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 708003)
Time Spent: 16h 10m (was: 16h)
> [Go SDK] Add automated expansion service start up feature
> ---------------------------------------------------------
>
> Key: BEAM-13399
> URL: https://issues.apache.org/jira/browse/BEAM-13399
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 16h 10m
> Remaining Estimate: 0h
>
> Add Go SDK support for automated expansion service start-up if one is not
> provided, following the example of the Python implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
