[
https://issues.apache.org/jira/browse/BEAM-5723?focusedWorklogId=221544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221544
]
ASF GitHub Bot logged work on BEAM-5723:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/19 23:38
Start Date: 01/Apr/19 23:38
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #8178:
[BEAM-5723] Do not use the default shadow closure when building CassandraIO
URL: https://github.com/apache/beam/pull/8178#discussion_r271088692
##########
File path: sdks/java/io/cassandra/build.gradle
##########
@@ -18,11 +18,23 @@
plugins { id 'org.apache.beam.module' }
// Do not relocate guava to avoid issues with Cassandra's version.
-applyJavaNature(shadowClosure: DEFAULT_SHADOW_CLOSURE << {
- dependencies {
- exclude(dependency(project.library.java.guava))
- }
-})
+applyJavaNature(
+ shadowClosure: {
+ dependencies {
+ // is default, but when omitted the default action is to include all
runtime deps
+ include(dependency(project.library.java.guava))
+
+ // hack: now exclude the only thing that was included
+ exclude(dependency(project.library.java.guava))
+
Review comment:
The default is the `runtime` configuration and it has to be overridden. We
never did that because we use the dependency filters.
Something that I think should work instead is this:
```groovy
shadowJar {
configurations = [project.configurations.compile]
}
```
I tried the above and it did not work. I think maybe it is the order of the
concatenation of the `shadowClosure` with the parts of the configuration that
are hardcoded into the main plugin. I am not sure. And I'm not sure if there is
a var I can just set `dependencies = []`. Basically we want to turn off the
shadow plugin here but I don't want to make such a big change.
I manually confirmed the contents of the jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 221544)
Time Spent: 9.5h (was: 9h 20m)
> CassandraIO is broken because of use of bad relocation of guava
> ---------------------------------------------------------------
>
> Key: BEAM-5723
> URL: https://issues.apache.org/jira/browse/BEAM-5723
> Project: Beam
> Issue Type: Bug
> Components: io-java-cassandra
> Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0, 2.9.0, 2.10.0, 2.11.0
> Reporter: Arun sethia
> Assignee: Ismaël Mejía
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> While using apache beam to run dataflow job to read data from BigQuery and
> Store/Write to Cassandra with following libaries:
> # beam-sdks-java-io-cassandra - 2.6.0
> # beam-sdks-java-io-jdbc - 2.6.0
> # beam-sdks-java-io-google-cloud-platform - 2.6.0
> # beam-sdks-java-core - 2.6.0
> # google-cloud-dataflow-java-sdk-all - 2.5.0
> # google-api-client -1.25.0
>
> I am getting following error at the time insert/save data to Cassandra.
> {code:java}
> [error] (run-main-0) org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NoSuchMethodError:
> com.datastax.driver.mapping.Mapper.saveAsync(Ljava/lang/Object;)Lorg/apache/beam/repackaged/beam_sdks_java_io_cassandra/com/google/common/util/concurrent/ListenableFuture;
> org.apache.beam.sdk.Pipeline$PipelineExecutionException:
> java.lang.NoSuchMethodError:
> com.datastax.driver.mapping.Mapper.saveAsync(Ljava/lang/Object;)Lorg/apache/beam/repackaged/beam_sdks_java_io_cassandra/com/google/common/util/concurrent/ListenableFuture;
> at
> org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:332)
> at
> org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:302)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:197)
> at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:64)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:313)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:299){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
