[
https://issues.apache.org/jira/browse/BEAM-13399?focusedWorklogId=719784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719784
]
ASF GitHub Bot logged work on BEAM-13399:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/22 00:26
Start Date: 03/Feb/22 00:26
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #16671:
URL: https://github.com/apache/beam/pull/16671#discussion_r798123253
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expand.go
##########
@@ -140,3 +142,67 @@ func QueryExpansionService(ctx context.Context, p
*HandlerParams) (*jobpb.Expans
}
return res, nil
}
+
+func startAutomatedExpansionService(gradleTarget string) (func() error,
string, error) {
+ jarPath, err := expansionx.GetBeamJar(gradleTarget, "2.35.0")
+ if err != nil {
+ return nil, "", err
+ }
+ serviceRunner, err := expansionx.NewExpansionServiceRunner(jarPath, "")
+ if err != nil {
+ return nil, "", err
+ }
+ err = serviceRunner.StartService()
+ if err != nil {
+ return nil, "", err
+ }
+ return serviceRunner.StopService, serviceRunner.Endpoint(), nil
+}
+
+// QueryAutomatedExpansionService submits an external transform to be expanded
by the
+// expansion service and then eagerly materializes the artifacts for staging.
The given
+// transform should be the external transform, and the components are any
additional
+// components necessary for the pipeline snippet.
+//
+// The address to be queried is determined by the Config field of the
HandlerParams after
+// the prefix tag indicating the automated service is in use.
+func QueryAutomatedExpansionService(ctx context.Context, p *HandlerParams)
(*jobpb.ExpansionResponse, error) {
+ // Strip auto: tag to get Gradle target
+ tag, target := parseAddr(p.Config)
Review comment:
What if we assume that "Config" only contains the Gradle target at this
point?
Wouldn't we be able to remove this parse and just populate the
autoJavaNamespace with this handler in the newRegistry() call then?
Then combined with a "Materialized" bit, we can then avoid even needing the
tag here.
I think we can do this in a next PR though, since these are just impl
details and I don't want to drag the scope for this much wider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 719784)
Time Spent: 23h 20m (was: 23h 10m)
> [Go SDK] Add automated expansion service start up feature
> ---------------------------------------------------------
>
> Key: BEAM-13399
> URL: https://issues.apache.org/jira/browse/BEAM-13399
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 23h 20m
> Remaining Estimate: 0h
>
> Add Go SDK support for automated expansion service start-up if one is not
> provided, following the example of the Python implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
