[ 
https://issues.apache.org/jira/browse/BEAM-13643?focusedWorklogId=720300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720300
 ]

ASF GitHub Bot logged work on BEAM-13643:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/22 17:48
            Start Date: 03/Feb/22 17:48
    Worklog Time Spent: 10m 
      Work Description: damondouglas commented on a change in pull request 
#16646:
URL: https://github.com/apache/beam/pull/16646#discussion_r798822490



##########
File path: playground/terraform/applications/backend-router/main.tf
##########
@@ -29,27 +29,30 @@ resource "google_app_engine_flexible_app_version" 
"backend_app_go" {
   }
 
   readiness_check {
-    path = ""
+    path = "/readiness"
   }
 
   automatic_scaling {
-    max_total_instances = 5
-    min_total_instances = 1
+    max_total_instances = 3

Review comment:
       @andreykus Perhaps in a future PR these can be terraform variables with 
recommended defaults.

##########
File path: playground/terraform/applications/backend-router/main.tf
##########
@@ -29,27 +29,30 @@ resource "google_app_engine_flexible_app_version" 
"backend_app_go" {
   }
 
   readiness_check {
-    path = ""
+    path = "/readiness"
   }
 
   automatic_scaling {
-    max_total_instances = 5
-    min_total_instances = 1
+    max_total_instances = 3
+    min_total_instances = 2
     cool_down_period = "120s"
     cpu_utilization {
       target_utilization = 0.7
     }
   }
 
   resources {
-    memory_gb = 4
-    cpu = 2
+    memory_gb = 16

Review comment:
       @andreykus Perhaps in a future PR these can be terraform variables with 
recommended defaults.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 720300)
    Time Spent: 50m  (was: 40m)

> [Playground] Setup running CI/CD for the SCIO SDK
> -------------------------------------------------
>
>                 Key: BEAM-13643
>                 URL: https://issues.apache.org/jira/browse/BEAM-13643
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-playground
>            Reporter: Aydar Zaynutdinov
>            Assignee: Andrey Kustov
>            Priority: P3
>              Labels: beam-playground-devops
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Setup running backend to verify SCIO SDK examples.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to