[ 
https://issues.apache.org/jira/browse/BEAM-13732?focusedWorklogId=723949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723949
 ]

ASF GitHub Bot logged work on BEAM-13732:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/22 19:47
            Start Date: 09/Feb/22 19:47
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on a change in pull request 
#16784:
URL: https://github.com/apache/beam/pull/16784#discussion_r803031040



##########
File path: sdks/java/io/google-cloud-platform/expansion-service/build.gradle
##########
@@ -35,5 +35,13 @@ dependencies {
     permitUnusedDeclared project(":sdks:java:expansion-service") // BEAM-11761
     implementation project(":sdks:java:io:google-cloud-platform")
     permitUnusedDeclared project(":sdks:java:io:google-cloud-platform") // 
BEAM-11761
+    implementation project(":sdks:java:extensions:schemaio-expansion-service")
+    permitUnusedDeclared 
project(":sdks:java:extensions:schemaio-expansion-service") // BEAM-11761

Review comment:
       Ok fair point, but regardless I think what we're both proposing is 
aligned. I'm just suggesting that instead of making a new extension to contain 
[`ExternalSchemaIOTransformRegistrar.java`](https://github.com/apache/beam/blob/master/sdks/java/extensions/schemaio-expansion-service/src/main/java/org/apache/beam/sdk/extensions/schemaio/expansion/ExternalSchemaIOTransformRegistrar.java)
 we can leave it where it is, and move away from publishing a shaded expansion 
service jar with it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 723949)
    Time Spent: 7h 20m  (was: 7h 10m)

> [Cross-Language] Implement Go SDK wrapper for xlang BigQuery IO
> ---------------------------------------------------------------
>
>                 Key: BEAM-13732
>                 URL: https://issues.apache.org/jira/browse/BEAM-13732
>             Project: Beam
>          Issue Type: New Feature
>          Components: cross-language, sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: P2
>             Fix For: 2.37.0
>
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> Title says it all.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to