[
https://issues.apache.org/jira/browse/BEAM-6935?focusedWorklogId=223114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223114
]
ASF GitHub Bot logged work on BEAM-6935:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 17:10
Start Date: 04/Apr/19 17:10
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #8220: [BEAM-6935]
Spark portable runner: implement side inputs
URL: https://github.com/apache/beam/pull/8220#discussion_r272279545
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/BoundedDataset.java
##########
@@ -69,6 +70,14 @@
return rdd;
}
+ List<byte[]> getBytes(WindowedValue.WindowedValueCoder<T> wvCoder) {
+ if (clientBytes == null) {
+ JavaRDDLike<byte[], ?> bytesRDD =
rdd.map(CoderHelpers.toByteFunction(wvCoder));
+ clientBytes = bytesRDD.collect();
Review comment:
`getBytes` implicitly assumes a 1:1 relationship between `this` and the
`wvCoder` argument, meaning the value of `bytesRDD.collect` would always be the
same for each BoundedDataset object and therefore would be cacheable. (This is
similar for the existing `getValues` function.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 223114)
Time Spent: 0.5h (was: 20m)
> Spark Portable Runner: Support side inputs
> ------------------------------------------
>
> Key: BEAM-6935
> URL: https://issues.apache.org/jira/browse/BEAM-6935
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
