[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=223323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223323
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 22:48
Start Date: 04/Apr/19 22:48
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8229: [BEAM-3545]
Support Metrics in Go SDK CombineFns- Part 2
URL: https://github.com/apache/beam/pull/8229#discussion_r272394806
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -79,6 +86,7 @@ func (n *ParDo) Up(ctx context.Context) error {
return nil
}
+// StartBundle starts processing for this bundle and does before bundle
processing operations.
Review comment:
Nvm, just realized how this is meant to be read. Maybe hyphenate it so it
says "pre-bundle-processing" to make it less ambiguous? It looks a bit funny
like that, but it's preferable to being difficult to parse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 223323)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: portability, triaged
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
