[
https://issues.apache.org/jira/browse/BEAM-6441?focusedWorklogId=225646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-225646
]
ASF GitHub Bot logged work on BEAM-6441:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/19 15:33
Start Date: 10/Apr/19 15:33
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #8226: [BEAM-6441] Add
script to set the version of Beam
URL: https://github.com/apache/beam/pull/8226#issuecomment-481741264
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 225646)
Time Spent: 1h 10m (was: 1h)
> cut_release_branch.sh should not push to master without verification and a PR
> -----------------------------------------------------------------------------
>
> Key: BEAM-6441
> URL: https://issues.apache.org/jira/browse/BEAM-6441
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Labels: triaged
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, the cut_release_branch.sh does many things:
> - Edits files in place to update the version
> - Makes a local commit
> - Pushing the local commit to master
> - Creates a new branch
> - Edits files in place to update the version
> - Pushes the release branch
> I think all of this except the push to master are OK. It is possible that we
> have something - website, examples, new places where the version is
> hardcoded, etc, that get broken in this process. Moving from x-SNAPSHOT to
> (x+1)-SNAPSHOT is easy to do in a pull request and safe. The release branch
> creation does not need to be synchronized with this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
