[
https://issues.apache.org/jira/browse/BEAM-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512570#comment-17512570
]
Luke Cwik commented on BEAM-14179:
----------------------------------
The required_labels field tells us which
https://github.com/apache/beam/blob/d62b5d6c43847a3b5ecb1321144cf10c6931bd98/model/pipeline/src/main/proto/metrics.proto#L311
labels are necessary.
This reduces the problem now down to what should be done when the value is
unknown.
> MonitoringInfoMetricName null value guard uncovering additional issues
> ----------------------------------------------------------------------
>
> Key: BEAM-14179
> URL: https://issues.apache.org/jira/browse/BEAM-14179
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Daniel Oliveira
> Priority: P2
> Fix For: 2.38.0
>
>
> Additional integration testing
> (//cloud/dataflow/testing/integration/sdk:V1ReadIT_testE2EV1Read) caught that
> https://github.com/apache/beam/pull/17094 causes a regression:
> The test failed with:
> {noformat}
> Caused by: java.lang.NullPointerException: null value in entry:
> DATASTORE_NAMESPACE=null
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:32)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:100)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.RegularImmutableMap.fromEntries(RegularImmutableMap.java:74)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:464)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:437)
> at
> org.apache.beam.runners.core.metrics.MonitoringInfoMetricName.<init>(MonitoringInfoMetricName.java:46)
> at
> org.apache.beam.runners.core.metrics.MonitoringInfoMetricName.named(MonitoringInfoMetricName.java:93)
> at
> org.apache.beam.runners.core.metrics.ServiceCallMetric.call(ServiceCallMetric.java:82)
> at
> org.apache.beam.sdk.io.gcp.datastore.DatastoreV1$Read$ReadFn.runQueryWithRetries(DatastoreV1.java:927)
> at
> org.apache.beam.sdk.io.gcp.datastore.DatastoreV1$Read$ReadFn.processElement(DatastoreV1.java:965)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
