[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=226284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226284
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/19 19:12
Start Date: 11/Apr/19 19:12
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #8272: [BEAM-4374]
Add Beam Distribution Accumulator to use in python's counter factory.
URL: https://github.com/apache/beam/pull/8272#discussion_r274600671
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -969,6 +969,11 @@ def
_verify_interpreter_version_is_supported(pipeline_options):
# To enable a counter on the service, add it to this dictionary.
+# This is required for the legacy python dataflow runner, as portability
+# does not communicate to the service via python code, but instead via a
+# a runner harness (in C++ or Java).
+# TODO(BEAM-7050) : Remove this antipattern, legacy dataflow python
+# pipelines will break whenever a new cy_combiner type is used.
Review comment:
to be fair, it currently breaks, but we can handle the failure and log
rather than just failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 226284)
Time Spent: 14h 20m (was: 14h 10m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
