[
https://issues.apache.org/jira/browse/BEAM-14235?focusedWorklogId=752572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752572
]
ASF GitHub Bot logged work on BEAM-14235:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/22 00:00
Start Date: 05/Apr/22 00:00
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17275:
URL: https://github.com/apache/beam/pull/17275#issuecomment-1088134978
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17275?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17275](https://codecov.io/gh/apache/beam/pull/17275?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(8213c5c) into
[master](https://codecov.io/gh/apache/beam/commit/8d5ca41992b3f4fda75e678fa5d517e5333bbb8a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(8d5ca41) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 8213c5c differs from pull request most recent
head d0888b4. Consider uploading reports for the commit d0888b4 to get more
accurate results
```diff
@@ Coverage Diff @@
## master #17275 +/- ##
==========================================
- Coverage 74.18% 74.17% -0.01%
==========================================
Files 675 675
Lines 88896 88920 +24
==========================================
+ Hits 65946 65957 +11
- Misses 21815 21828 +13
Partials 1135 1135
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.69% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/parquetio.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vcGFycXVldGlvLnB5)
| `96.13% <100.00%> (+0.04%)` | :arrow_up: |
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `87.80% <0.00%> (-7.32%)` | :arrow_down: |
|
[.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5)
| `96.72% <0.00%> (-1.64%)` | :arrow_down: |
|
[...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==)
| `92.25% <0.00%> (-0.81%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5)
| `91.47% <0.00%> (-0.78%)` | :arrow_down: |
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `81.09% <0.00%> (-0.73%)` | :arrow_down: |
|
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
| `92.25% <0.00%> (-0.71%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=)
| `96.46% <0.00%> (-0.55%)` | :arrow_down: |
|
[...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=)
| `85.85% <0.00%> (-0.51%)` | :arrow_down: |
|
[...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==)
| `90.21% <0.00%> (-0.31%)` | :arrow_down: |
| ... and [8
more](https://codecov.io/gh/apache/beam/pull/17275/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17275?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17275?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[8d5ca41...d0888b4](https://codecov.io/gh/apache/beam/pull/17275?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 752572)
Time Spent: 1h 10m (was: 1h)
> parquetio module does not parse PEP-440 compliant Pyarrow version
> -----------------------------------------------------------------
>
> Key: BEAM-14235
> URL: https://issues.apache.org/jira/browse/BEAM-14235
> Project: Beam
> Issue Type: Bug
> Components: io-py-parquet
> Affects Versions: 2.27.0
> Reporter: Arwin S Tio
> Priority: P3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In version > 2.27, introduced by this PR:
> [https://github.com/apache/beam/pull/13302/files#diff-33b0b6b112036df96f341aa83b88efba9215ec14dfabc9db9e9ffe66a23154a2R55]
> The parquetio module parses the pyarrow version like this:
> {code:java}
> ARROW_MAJOR_VERSION, _, _ = map(int, pa.__version__.split('.')) {code}
> (see
> [https://github.com/apache/beam/blob/v2.27.0/sdks/python/apache_beam/io/parquetio.py#L55)]
>
> This does not support all PEP-440 compliant versions:
> [https://peps.python.org/pep-0440/]
>
> For example, if pyarrow were to have a version like this: *1.0.0+abc.7,* then
> this module would fail:
> {code:java}
> Traceback (most recent call last):
> File "/usr/local/lib/python3.7/runpy.py", line 183, in _run_module_as_main
> mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
> File "/usr/local/lib/python3.7/runpy.py", line 109, in _get_module_details
> __import__(pkg_name)
> File "/usr/local/lib/python3.7/site-packages/apache_beam/__init__.py", line
> 93, in <module>
> from apache_beam import io
> File "/usr/local/lib/python3.7/site-packages/apache_beam/io/__init__.py",
> line 28, in <module>
> from apache_beam.io.parquetio import *
> File "/usr/local/lib/python3.7/site-packages/apache_beam/io/parquetio.py",
> line 53, in <module>
> ARROW_MAJOR_VERSION, _, _ = map(int, pa.__version__.split('.'))
> ValueError: invalid literal for int() with base 10: '0+abc.7'{code}
>
> In practice, this would fail when somebody forks pyarrow, like yours truly.
>
> We can fix this by using *pkg_resourses.parse_version* which is PEP-440
> compliant starting setuptools 6.0.
>
> If maintainers agree with this change I would be wiling to submit a PR.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
