[
https://issues.apache.org/jira/browse/BEAM-14288?focusedWorklogId=755868&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755868
]
ASF GitHub Bot logged work on BEAM-14288:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/22 16:33
Start Date: 12/Apr/22 16:33
Worklog Time Spent: 10m
Work Description: KevinGG opened a new pull request, #17351:
URL: https://github.com/apache/beam/pull/17351
Use assertIn instead of assertEqual when asserting formatted dict
because the order of accessing entries in a dict is non-deterministic.
This includes repr(x: dict).
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 755868)
Time Spent: 1h (was: 50m)
> Python PreCommit flaking in test_pformat_namedtuple_with_unnamed_fields
> -----------------------------------------------------------------------
>
> Key: BEAM-14288
> URL: https://issues.apache.org/jira/browse/BEAM-14288
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, test-failures
> Reporter: Brian Hulette
> Assignee: Ning
> Priority: P1
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code}
> self = <apache_beam.runners.interactive.sql.utils_test.UtilsTest
> testMethod=test_pformat_namedtuple_with_unnamed_fields>
> def test_pformat_namedtuple_with_unnamed_fields(self):
> > self.assertEqual(
> f'OptionalUnionType(unnamed: {repr(Optional[Union[int, str]])})',
> pformat_namedtuple(OptionalUnionType))
> E AssertionError: 'OptionalUnionType(unnamed: typing.Union[str, int,
> NoneType])' != 'OptionalUnionType(unnamed: typing.Union[int, str, NoneType])'
> E - OptionalUnionType(unnamed: typing.Union[str, int, NoneType])
> E ? -----
> E + OptionalUnionType(unnamed: typing.Union[int, str, NoneType])
> E ? +++++
> apache_beam/runners/interactive/sql/utils_test.py:83: AssertionError
> {code}
> Hard to tell if this is a flake or a hard failure. If it's a hard failure, it
> just started recently in cron run
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/5498/
> In the runs I've seen since then the failure does seem consistent, but it
> might only be affecting certain environments (py37-cloud, py39-cloud,
> py38-cloudcoverage)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
