[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=756524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756524
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/22 16:49
Start Date: 13/Apr/22 16:49
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17334:
URL: https://github.com/apache/beam/pull/17334#discussion_r849696275
##########
sdks/go/pkg/beam/core/runtime/exec/pardo.go:
##########
@@ -144,12 +145,13 @@ func (n *ParDo) processMainInput(mainIn *MainInput) error
{
// is that either there is a single window or the function doesn't
observe windows, so we can
// optimize it by treating all windows as a single one.
if !mustExplodeWindows(n.inv.fn, elm, len(n.Side) > 0) {
- return n.processSingleWindow(mainIn)
+ _, processResult := n.processSingleWindow(mainIn)
Review Comment:
Done
##########
sdks/go/pkg/beam/core/runtime/exec/sdf.go:
##########
@@ -343,7 +347,11 @@ func (n *ProcessSizedElementsAndRestrictions)
ProcessElement(_ context.Context,
defer func() {
<-n.SU
}()
- return n.PDo.processSingleWindow(mainIn)
+ continuation, processResult := n.PDo.processSingleWindow(mainIn)
+ if continuation != nil {
+ n.continuation = continuation
+ }
Review Comment:
That's fair.
Issue Time Tracking
-------------------
Worklog Id: (was: 756524)
Time Spent: 9h 50m (was: 9h 40m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> Design doc:
> https://docs.google.com/document/d/1_JbzjY9JR07ZK5v7PcZevUfzHPsqwzfV7W6AouNpMPk/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
