[
https://issues.apache.org/jira/browse/BEAM-6942?focusedWorklogId=226951&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226951
]
ASF GitHub Bot logged work on BEAM-6942:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/19 21:44
Start Date: 12/Apr/19 21:44
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8225: [BEAM-6942]
Make modifications to pipeline options to be visible to all views.
URL: https://github.com/apache/beam/pull/8225#discussion_r275073307
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -738,13 +801,13 @@ def _add_argparse_args(cls, parser):
'"<ENV_VAL>"} }. All fields in the json are optional except '
'command.'))
parser.add_argument(
- '--sdk-worker-parallelism', default=None,
+ '--sdk_worker_parallelism', default=None,
Review comment:
This may help clarify argparse behavior:
```
In [1]: import argparse
In [2]: parser=argparse.ArgumentParser()
In [3]: parser.add_argument('--flag-with-dash')
Out[3]: _StoreAction(option_strings=['--flag-with-dash'],
dest='flag_with_dash', nargs=None, const=None, default=None, type=None,
choices=None, help=None, metavar=None)
In [5]: parser.parse_args(['--flag-with-dash=abc'])
Out[5]: Namespace(flag_with_dash='abc')
In [6]: parser.parse_args(['--flag_with_dash=I am using underscores instead
of dashes in flag name!'])
usage: ipython [-h] [--flag-with-dash FLAG_WITH_DASH]
ipython: error: unrecognized arguments: --flag_with_dash=I am using
underscores instead of dashes in flag name!
An exception has occurred, use %tb to see the full traceback.
In [7]: parser.add_argument('--flag_with_dash')
Out[7]: _StoreAction(option_strings=['--flag_with_dash'],
dest='flag_with_dash', nargs=None, const=None, default=None, type=None,
choices=None, help=None, metavar=None)
In [8]: parser.parse_args(['--flag_with_dash=Now I can use both dashes and
underscores'])
Out[8]: Namespace(flag_with_dash='Now I can use both dashes and underscores')
In [9]: parser.parse_args(['--flag-with-dash=Same store is used for flags
with dashes and underscores'])
Out[9]: Namespace(flag_with_dash='Same store is used for flags with dashes
and underscores')
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 226951)
Time Spent: 11h (was: 10h 50m)
> Pipeline options to experiment propagation is not working in Dataflow runner.
> -----------------------------------------------------------------------------
>
> Key: BEAM-6942
> URL: https://issues.apache.org/jira/browse/BEAM-6942
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 11h
> Remaining Estimate: 0h
>
> Relevant code:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L356-L388]
> 3 experiments/options are affected. We need to fix it in 2.12.0
> cc: [~altay] [~apilloud]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
