[
https://issues.apache.org/jira/browse/BEAM-14290?focusedWorklogId=757100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757100
]
ASF GitHub Bot logged work on BEAM-14290:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/22 17:07
Start Date: 14/Apr/22 17:07
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17373:
URL: https://github.com/apache/beam/pull/17373#issuecomment-1099419009
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17373](https://codecov.io/gh/apache/beam/pull/17373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(213a6b4) into
[master](https://codecov.io/gh/apache/beam/commit/73c683fe2b0a02ae7a5327e0cdf2991079ca3500?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(73c683f) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17373 +/- ##
==========================================
- Coverage 73.76% 73.76% -0.01%
==========================================
Files 686 686
Lines 90117 90116 -1
==========================================
- Hits 66477 66476 -1
Misses 22470 22470
Partials 1170 1170
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.34% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/util/reflectx/calls.go](https://codecov.io/gh/apache/beam/pull/17373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvY2FsbHMuZ28=)
| `0.00% <ø> (ø)` | |
|
[sdks/go/pkg/beam/core/util/reflectx/call.go](https://codecov.io/gh/apache/beam/pull/17373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvY2FsbC5nbw==)
| `89.74% <100.00%> (ø)` | |
|
[sdks/go/pkg/beam/core/util/reflectx/types.go](https://codecov.io/gh/apache/beam/pull/17373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvdHlwZXMuZ28=)
| `94.59% <100.00%> (-0.15%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[73c683f...213a6b4](https://codecov.io/gh/apache/beam/pull/17373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 757100)
Time Spent: 40m (was: 0.5h)
> Address Staticcheck warnings in the reflectx package
> ----------------------------------------------------
>
> Key: BEAM-14290
> URL: https://issues.apache.org/jira/browse/BEAM-14290
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> * Update make() calls in call.go
> * Remove unnecessary blank identifier assignments in call_test.go
> * Merge variable declaration with assignment in types.go
> * Merge variable declaration with assignment in types_test.go
> * Updates calls.tmpl to include a file-ignore for S1023 since the file is
> generated
> ** Then regenerate file with go generate
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
