[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=758498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758498
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/22 14:25
Start Date: 19/Apr/22 14:25
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17386:
URL: https://github.com/apache/beam/pull/17386#discussion_r853141017
##########
sdks/go/pkg/beam/core/runtime/harness/harness.go:
##########
@@ -401,11 +402,34 @@ func (c *control) handleInstruction(ctx context.Context,
req *fnpb.InstructionRe
c.plans[bdID] = append(c.plans[bdID], plan)
}
}
+
+ // Check if the underlying DoFn self-checkpointed.
+ // TODO(BEAM-11104): How should a returned error here be
handled to avoid clobbering
+ // an error that is returned after the mutex is given up?
Review Comment:
Yeah I'm thinking the original error would be more important than a
checkpoint failing. I was trying to decide if it was important to include both,
but it makes sense that the first error should be prioritized.
Issue Time Tracking
-------------------
Worklog Id: (was: 758498)
Time Spent: 13.5h (was: 13h 20m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> Design doc:
> https://docs.google.com/document/d/1_JbzjY9JR07ZK5v7PcZevUfzHPsqwzfV7W6AouNpMPk/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
