[
https://issues.apache.org/jira/browse/BEAM-10265?focusedWorklogId=764239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764239
]
ASF GitHub Bot logged work on BEAM-10265:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/22 13:35
Start Date: 29/Apr/22 13:35
Worklog Time Spent: 10m
Work Description: andreigurau commented on code in PR #17477:
URL: https://github.com/apache/beam/pull/17477#discussion_r861805473
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java:
##########
@@ -156,6 +165,16 @@ static Schema getSchema(Class<? extends Message> clazz) {
}
static Schema getSchema(Descriptors.Descriptor descriptor) {
Review Comment:
I get why it may not be multi-thread safe, but why are you saying it is ok
to leave it as is? I will say that this change doesn't seem to fail any
existing tests
Also, I created a Javadoc for this function, but I doubt I did it correctly.
I'm not sure what the standards are exactly, but I tried to copy what I've seen
from other examples (also I haven't worked with Javadocs much in general). Let
me know if there's anything that needs to be changed
Issue Time Tracking
-------------------
Worklog Id: (was: 764239)
Time Spent: 2.5h (was: 2h 20m)
> GetterBasedSchemaProvider#schemaFor stack overflows when given a recursive
> schema
> ---------------------------------------------------------------------------------
>
> Key: BEAM-10265
> URL: https://issues.apache.org/jira/browse/BEAM-10265
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.21.0, 2.22.0
> Reporter: Reza ardeshir rokni
> Assignee: Andrei Gurau
> Priority: P3
> Labels: Clarified, starter
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Proto:
> message TSFoo {
> string a = 1;
> string b = 2;
> TSFoo theOlderMe = 3;
> }
> new ProtoMessageSchema().schemaFor(TypeDescriptor.of(Foo.TSFoo.class));
> Causes a stackoverflow.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
