[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=766181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766181
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/22 17:19
Start Date: 04/May/22 17:19
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17543:
URL: https://github.com/apache/beam/pull/17543#discussion_r865084625
##########
sdks/go/pkg/beam/core/runtime/exec/pardo.go:
##########
@@ -180,6 +180,10 @@ func (n *ParDo) processSingleWindow(mainIn *MainInput)
(sdf.ProcessContinuation,
// Forward direct output, if any. It is always a main output.
if val != nil {
+ // We do not forward a ProcessContinuation on its own
+ if val.Elm == nil && val.Continuation != nil {
Review Comment:
```suggestion
if val.Elm == nil {
```
Probably not a huge deal since we should never(?) get into a situation where
val != nil && val.Elm == nil && val.Continuation == nil, but this simplifies
things and helps us avoid potential for the same kind of issue.
Issue Time Tracking
-------------------
Worklog Id: (was: 766181)
Time Spent: 18h 10m (was: 18h)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 18h 10m
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> Design doc:
> [https://docs.google.com/document/d/1_JbzjY9JR07ZK5v7PcZevUfzHPsqwzfV7W6AouNpMPk/edit?usp=sharing]
>
> Feature is written E2E and users will be able to return ProcessContinuations
> from SDFs as of 2.39.0 but the full behavior has not been fully validated. An
> integration test that validates self-checkpointing is working as-intended
> will need to be written and passing before the feature is no longer
> considered experimental and this ticket is marked as resolved.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
