[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=768769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768769
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/22 23:42
Start Date: 10/May/22 23:42
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17590:
URL: https://github.com/apache/beam/pull/17590#discussion_r869757984
##########
sdks/go/test/integration/primitives/checkpointing_test.go:
##########
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package primitives
+
+import (
+ "testing"
+
+ "github.com/apache/beam/sdks/v2/go/pkg/beam"
+ _ "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem/local"
+ _ "github.com/apache/beam/sdks/v2/go/pkg/beam/runners/dataflow"
+ _ "github.com/apache/beam/sdks/v2/go/pkg/beam/runners/flink"
+ _ "github.com/apache/beam/sdks/v2/go/pkg/beam/runners/samza"
+ _ "github.com/apache/beam/sdks/v2/go/pkg/beam/runners/spark"
Review Comment:
We should be able to remove these `_` imports since they are already handled
in
https://github.com/apache/beam/blob/87f9fa9c02a186e5a3c01d8c20af10454eeb8ab8/sdks/go/test/integration/primitives/primitives_test.go
Issue Time Tracking
-------------------
Worklog Id: (was: 768769)
Time Spent: 25h (was: 24h 50m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 25h
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> Design doc:
> [https://docs.google.com/document/d/1_JbzjY9JR07ZK5v7PcZevUfzHPsqwzfV7W6AouNpMPk/edit?usp=sharing]
>
> Feature is written E2E and users will be able to return ProcessContinuations
> from SDFs as of 2.39.0 but the full behavior has not been fully validated. An
> integration test that validates self-checkpointing is working as-intended
> will need to be written and passing before the feature is no longer
> considered experimental and this ticket is marked as resolved.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
