[
https://issues.apache.org/jira/browse/BEAM-14347?focusedWorklogId=769086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769086
]
ASF GitHub Bot logged work on BEAM-14347:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 14:00
Start Date: 11/May/22 14:00
Worklog Time Spent: 10m
Work Description: damccorm opened a new pull request, #17613:
URL: https://github.com/apache/beam/pull/17613
This adds some basic benchmarks to prove that the generic registration works
as well as the generated version. This isn't really perfect - it largely looks
at pieces of the overall flow and doesn't provide a comprehensive full run of
the DoFn, and it misses some cases (e.g. iters/emitters). This is because:
1) We can't have these benchmarks in the exec package because including the
register package there induces a circular dependency and go test throws.
2) Much of the stuff we'd like to be able to easily test is private in exec.
An example is that makeEmit is private, and its pretty challenging to test that
specific functionality.
I didn't try _too_ hard to work around those constraints because I expect
that once we've built up a decent history of load test runs that will actually
be a better way to show that generic registration is just as good for more
"real" use cases.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 769086)
Time Spent: 13h (was: 12h 50m)
> [Go SDK] Allow users to optimize DoFns with a single generic registration
> function
> ----------------------------------------------------------------------------------
>
> Key: BEAM-14347
> URL: https://issues.apache.org/jira/browse/BEAM-14347
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Danny McCormick
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 13h
> Remaining Estimate: 0h
>
> Right now, to optimize DoFn execution, users have to use the code generator.
> This updates to allow them to use generics instead.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
