[
https://issues.apache.org/jira/browse/BEAM-14470?focusedWorklogId=770529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770529
]
ASF GitHub Bot logged work on BEAM-14470:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/22 22:45
Start Date: 14/May/22 22:45
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17673:
URL: https://github.com/apache/beam/pull/17673#discussion_r873082283
##########
sdks/go/test/load/sideinput/sideinput.go:
##########
@@ -51,11 +54,17 @@ func parseSyntheticConfig() synthetic.SourceConfig {
}
}
+// impToKV just turns an impulse signal into a KV instead of
+// adding a single value input version of RuntimeMonitor
+func impToKV(imp []byte, emit func([]byte, []byte)) {
+ emit(imp, imp)
+}
+
type doFn struct {
Review Comment:
The focus for this one is that it uses an iterator, so calling that one out,
so it's easier to add a Dictionary based one later.
##########
sdks/go/test/load/sideinput/sideinput.go:
##########
@@ -51,11 +54,17 @@ func parseSyntheticConfig() synthetic.SourceConfig {
}
}
+// impToKV just turns an impulse signal into a KV instead of
+// adding a single value input version of RuntimeMonitor
+func impToKV(imp []byte, emit func([]byte, []byte)) {
+ emit(imp, imp)
+}
+
type doFn struct {
Review Comment:
The focus for this one is that it uses an iterator, so calling that one out,
so it's easier to add a map based one later.
Issue Time Tracking
-------------------
Worklog Id: (was: 770529)
Time Spent: 1h 10m (was: 1h)
> Optimize load tests w/generic registrations
> -------------------------------------------
>
> Key: BEAM-14470
> URL: https://issues.apache.org/jira/browse/BEAM-14470
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, testing
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> With Generic Registration available, a way to indicate the value would be via
> the load tests.
> In particular the following tests should be optimized:
> http://metrics.beam.apache.org/d/fK0U4JqWz/cogbk-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/WNzYt13Zk/combine-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/UYZ-oJ3Zk/gbk-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/MOi-kf3Zk/pardo-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/-E9aGlFGk/side-input-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> Benchmarks show reduce per call overhead by about ~300ns per parameter in the
> invoked user function, just like the code generated, and any improvement
> should be reflected by the load test graphs going forward.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
