[
https://issues.apache.org/jira/browse/BEAM-14451?focusedWorklogId=772032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772032
]
ASF GitHub Bot logged work on BEAM-14451:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/May/22 17:03
Start Date: 18/May/22 17:03
Worklog Time Spent: 10m
Work Description: msbukal commented on code in PR #17598:
URL: https://github.com/apache/beam/pull/17598#discussion_r876136158
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIOTest.java:
##########
@@ -146,4 +151,17 @@ public void test_FhirIO_failedPatientEverything() {
PAssert.that(everythingResult.getPatientCompartments()).empty();
pipeline.run();
}
+
+ @Test
+ public void test_FhirIO_Export_invalidUri() {
+ final String invalidUri = "someInvalidUri";
+ pipeline
+ .apply(Create.of(Arrays.asList("resource1", "resource2")))
Review Comment:
What's the point of this line? Also just call FhirIO.exportResources(...)
same as the other tests
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:
##########
@@ -194,11 +193,11 @@
* FhirIO.Write.Result writeResult =
* output.apply("Import FHIR Resources",
FhirIO.executeBundles(options.getNewFhirStore()));
*
- * // Export FHIR resources to Google Cloud Storage.
+ * // Export FHIR resources to Google Cloud Storage or BigQuery.
Review Comment:
Can you also update the comment on line 135 (just add BigQuery)
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:
##########
@@ -1518,6 +1508,7 @@ private int parseBundleStatus(String status) {
/**
* Export FHIR resources from a FHIR store to new line delimited json files
on GCS or BigQuery.
+ * Output PCollection should contain the URI where the FHIR store was
exported to.
Review Comment:
should contain -> contains
Issue Time Tracking
-------------------
Worklog Id: (was: 772032)
Time Spent: 2h 10m (was: 2h)
> Add Export to BQ to FhirIO.Export
> ---------------------------------
>
> Key: BEAM-14451
> URL: https://issues.apache.org/jira/browse/BEAM-14451
> Project: Beam
> Issue Type: Improvement
> Components: io-java-healthcare
> Reporter: Milena Bukal
> Assignee: Milena Bukal
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Documentation for Export to BQ:
> [https://cloud.google.com/healthcare-api/docs/how-tos/fhir-export-bigquery,]
> currently only GCS (
> [https://cloud.google.com/healthcare-api/docs/how-tos/fhir-import-export#exporting_fhir_resources])
> is implemented.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
