[ 
https://issues.apache.org/jira/browse/BEAM-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17548783#comment-17548783
 ] 

Danny McCormick commented on BEAM-10604:
----------------------------------------

This issue has been migrated to https://github.com/apache/beam/issues/20398

> Remove "final" modifier from FileBasedSource#getEstimatedSizeBytes?
> -------------------------------------------------------------------
>
>                 Key: BEAM-10604
>                 URL: https://issues.apache.org/jira/browse/BEAM-10604
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Claire McGinty
>            Priority: P3
>              Labels: Clarified
>
> https://github.com/apache/beam/blob/6fdde4f4eab72b49b10a8bb1cb3be263c5c416b5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java#L215
> Can we remove the "final" modifier here so subclasses have the option to 
> override? I have a subclass implementation that performs best with a 
> different size estimation heuristic. Similar case with the #split method.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to