[
https://issues.apache.org/jira/browse/BEAM-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829263#comment-16829263
]
Michael Luckey edited comment on BEAM-4046 at 4/29/19 1:24 PM:
---------------------------------------------------------------
[~kenn], [~lcwik]
After keeping that open for a while, I would like to revive discussion on how
to proceed with this ticket.
Tests seem to be successful. So main point of discussion would be
- do we want to apply this change or just keep current state and drop this
ticket
- if we want to proceed, please take a look at the 'backwards compatibility'
hack introduced [1]. After looking into the requirements, it seemed easiest to
me to just rewrite gradle cli params. So I moved gradlew shell script to
gradlew_orig and just do some args rewriting. This seems to work (as Jenkins is
still able to execute all tests without seeding of changed jobs). We probably
should move to posix shell here and maybe put some love into that
implementation. Also we might need to implement similar for windows (not sure
though, whether that's really used)
So if we want to continue, I would do some final testing and would like to
merge after cut of next release branch. Currently it is difficult to keep pace
with the changes done to master.
[1]
https://github.com/apache/beam/pull/8194/commits/c8685a8ca7a4a0366f5f0aac63ea5e1e7d8e5bb8
was (Author: michel):
[~kenn], [~lcwik]
After keeping that open for a while, I would like to revive discussion on how
to proceed with this ticket.
Tests seem to be successful. So main point of discussion would be
- do we want to apply this change or just keep current state and drop this
ticket
- if we want to proceed, please take a look at the 'backwards compatibility'
hack introduced. After looking into the requirements, it seemed easiest to me
to just rewrite gradle cli params. So I moved gradlew shell script to
gradlew_orig and just do some args rewriting. This seems to work (as Jenkins is
still able to execute all tests without seeding of changed jobs). We probably
should move to posix shell here and maybe put some love into that
implementation. Also we might need to implement similar for windows (not sure
though, whether that's really used)
So if we want to continue, I would do some final testing and would like to
merge after cut of next release branch. Currently it is difficult to keep pace
with the changes done to master.
> Decouple gradle project names and maven artifact ids
> ----------------------------------------------------
>
> Key: BEAM-4046
> URL: https://issues.apache.org/jira/browse/BEAM-4046
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 20h
> Remaining Estimate: 0h
>
> In our first draft, we had gradle projects like {{":beam-sdks-java-core"}}.
> It is clumsy and requires a hacky settings.gradle that is not idiomatic.
> In our second draft, we changed them to names that work well with Gradle,
> like {{":sdks:java:core"}}. This caused Maven artifact IDs to be wonky.
> In our third draft, we regressed to the first draft to get the Maven artifact
> ids right.
> These should be able to be decoupled. It seems there are many StackOverflow
> questions on the subject.
> Since it is unidiomatic and a poor user experience, if it does turn out to be
> mandatory then it needs to be documented inline everywhere - the
> settings.gradle should say why it is so bizarre, and each build.gradle should
> indicate what its project id is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
