[
https://issues.apache.org/jira/browse/BEAM-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834077#comment-16834077
]
Raghu Angadi commented on BEAM-7143:
------------------------------------
Yes, it will be good to go with 'with' prefix to be consistent with other API.
I added the 'update' api initially, and always felt bad about it. Thanks for
fixing it.
For transition, we can keep both old and new, with old API deprecated. It could
log a warning to ask user to use new API. The old API can be deleted in next
major version.
> adding withConsumerConfigUpdates
> --------------------------------
>
> Key: BEAM-7143
> URL: https://issues.apache.org/jira/browse/BEAM-7143
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To modify `ConsumerConfig` for main consumer, we use
> `updateConsumerProperties`. However, to modify `ConsumerConfig` for offset
> consumer, the right method is `withOffsetConsumerConfigOverrides`. It would
> be good to match both names for improving usability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
