[
https://issues.apache.org/jira/browse/BEAM-7235?focusedWorklogId=239471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239471
]
ASF GitHub Bot logged work on BEAM-7235:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 20:44
Start Date: 08/May/19 20:44
Worklog Time Spent: 10m
Work Description: scwhittle commented on pull request #8512: [BEAM-7235]
StreamingDataflowWorker creates commit stream only when commit available
URL: https://github.com/apache/beam/pull/8512#discussion_r282242048
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -1508,8 +1513,10 @@ private void streamingCommitLoop() {
break;
}
}
- commitStream.flush();
- streamPool.releaseStream(commitStream);
+ if (commitStream) {
Review comment:
Oops, fixed,
I ran the following ./gradlew :beam-runners-google-cloud-dataflow-java:build
does that not actually build this? Or perhaps I ran it in the wrong branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 239471)
Time Spent: 1h 10m (was: 1h)
> GrpcWindmillServer creates commit streams before necessary
> ----------------------------------------------------------
>
> Key: BEAM-7235
> URL: https://issues.apache.org/jira/browse/BEAM-7235
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This can cause spammy logs if there are no commits before the stream deadline
> is reached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
