[ https://issues.apache.org/jira/browse/BEAM-7263?focusedWorklogId=240095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240095 ]
ASF GitHub Bot logged work on BEAM-7263: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/May/19 08:07 Start Date: 10/May/19 08:07 Worklog Time Spent: 10m Work Description: iemejia commented on pull request #8547: [BEAM-7263] Deprecate set/getClientConfiguration in JdbcIO URL: https://github.com/apache/beam/pull/8547 This is a minor clean up to clean the two methods because they are not used internally anymore, the ClientConfiguration is just wrapped and passed as a function to `withDataSourceProviderFn`. This has almost zero impact on end users because the set functionality is already covetred by the `with` method and the `get` method is not mandatory because the user already has the reference. R: @jbonofre ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 240095) Time Spent: 10m Remaining Estimate: 0h > Deprecate set/getClientConfiguration in JdbcIO > ---------------------------------------------- > > Key: BEAM-7263 > URL: https://issues.apache.org/jira/browse/BEAM-7263 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc > Reporter: Ismaël Mejía > Assignee: Ismaël Mejía > Priority: Minor > Fix For: 2.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > JdbcIO relies now on `withDataSourceProviderFn` as the primary way to build a > DataSource, the main method used to do this is `withDatasourceConfiguration` > relies now on it, so the 'interna' method to get the object should not be > exposed anymore. -- This message was sent by Atlassian JIRA (v7.6.3#76005)