[
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=240120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240120
]
ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/19 08:47
Start Date: 10/May/19 08:47
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #8400: [BEAM-6627]
Added byte and item counting metrics to integration tests
URL: https://github.com/apache/beam/pull/8400#discussion_r282798257
##########
File path:
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
##########
@@ -148,6 +150,16 @@ private void gatherAndPublishMetrics(PipelineResult
writeResult, PipelineResult
return NamedTestResult.create(
uuid, timestamp, "write_time", (writeEnd - writeStart) / 1e3);
});
+ suppliers.add(
+ reader -> {
+ double totalBytes = reader.getCounterMetric("write_bytes");
+ return NamedTestResult.create(uuid, timestamp, "write_bytes",
totalBytes);
Review comment:
There's no need to collect bytes/items separately for write & read. If it
will be different the PAssert will fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 240120)
Time Spent: 14h 10m (was: 14h)
> Use Metrics API in IO performance tests
> ---------------------------------------
>
> Key: BEAM-6627
> URL: https://issues.apache.org/jira/browse/BEAM-6627
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
