[
https://issues.apache.org/jira/browse/BEAM-6683?focusedWorklogId=243555&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243555
]
ASF GitHub Bot logged work on BEAM-6683:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/19 18:36
Start Date: 16/May/19 18:36
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #8174:
[BEAM-6683] add createCrossLanguageValidatesRunner task
URL: https://github.com/apache/beam/pull/8174#discussion_r284839973
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1625,6 +1645,110 @@ class BeamModulePlugin implements Plugin<Project> {
/**
***********************************************************************************************/
+ // Method to create the crossLanguageValidatesRunnerTask.
+ // The method takes crossLanguageValidatesRunnerConfiguration as parameter.
+ project.ext.createCrossLanguageValidatesRunnerTask = {
+ def config = it ? it as CrossLanguageValidatesRunnerConfiguration : new
CrossLanguageValidatesRunnerConfiguration()
+
+ project.evaluationDependsOn(":sdks:python")
+ project.evaluationDependsOn(":sdks:java:testing:expansion-service")
+ project.evaluationDependsOn(":runners:core-construction-java")
+
+ // Task for launching expansion services
+ def envDir = project.project(":sdks:python").envdir
+ def pythonDir = project.project(":sdks:python").projectDir
+ def javaPort = startingExpansionPortNumber.getAndDecrement()
+ def pythonPort = startingExpansionPortNumber.getAndDecrement()
+ def expansionJar =
project.project(':sdks:java:testing:expansion-service').buildTestExpansionServiceJar.archivePath
+ def expansionServiceOpts = [
+ "group_id": project.name,
+ "java_expansion_service_jar": expansionJar,
+ "java_port": javaPort,
+ "python_virtualenv_dir": envDir,
+ "python_expansion_service_module":
"apache_beam.runners.portability.expansion_service_test",
+ "python_port": pythonPort
+ ]
+ def serviceArgs =
project.project(':sdks:python').mapToArgString(expansionServiceOpts)
+ def setupTask = project.tasks.create(name: config.name+"Setup", type:
Exec) {
+ dependsOn ':sdks:java:container:docker'
+ dependsOn ':sdks:python:container:docker'
+ dependsOn
':sdks:java:testing:expansion-service:buildTestExpansionServiceJar'
+ dependsOn ":sdks:python:installGcpTest"
+ // setup test env
+ executable 'sh'
+ args '-c', "$pythonDir/scripts/run_expansion_services.sh stop
--group_id ${project.name} && $pythonDir/scripts/run_expansion_services.sh
start $serviceArgs"
+ }
+
+ def mainTask = project.tasks.create(name: config.name) {
+ group = "Verification"
+ description = "Validates cross-language capability of runner"
+ }
+
+ def cleanupTask = project.tasks.create(name: config.name+'Cleanup',
type: Exec) {
+ // teardown test env
+ executable 'sh'
+ args '-c', "$pythonDir/scripts/run_expansion_services.sh stop
--group_id ${project.name}"
+ }
+ setupTask.finalizedBy cleanupTask
+
+ // Task for running testcases in Java SDK
+ def beamJavaTestPipelineOptions = [
+
"--runner=org.apache.beam.runners.reference.testing.TestPortableRunner",
+ "--jobServerDriver=${config.jobServerDriver}",
+ "--environmentCacheMillis=10000"
+ ]
+ beamJavaTestPipelineOptions.addAll(config.pipelineOpts)
+ if (config.jobServerConfig) {
+
beamJavaTestPipelineOptions.add("--jobServerConfig=${config.jobServerConfig}")
+ }
+ ['Java': javaPort, 'Python': pythonPort].each { sdk, port ->
+ def javaTask = project.tasks.create(name: config.name+"JavaUsing"+sdk,
type: Test) {
+ group = "Verification"
+ description = "Validates runner for cross-language capability of
using ${sdk} transforms from Java SDK"
+ systemProperty "beamTestPipelineOptions",
JsonOutput.toJson(beamJavaTestPipelineOptions)
+ systemProperty "expansionPort", port
+ classpath = config.testClasspathConfiguration
+ testClassesDirs =
project.files(project.project(":runners:core-construction-java").sourceSets.test.output.classesDirs)
+ maxParallelForks config.numParallelTests
+ useJUnit(config.testCategories)
+ // increase maxHeapSize as this is directly correlated to direct
memory,
+ // see https://issues.apache.org/jira/browse/BEAM-6698
+ maxHeapSize = '4g'
+ dependsOn setupTask
+ }
+ mainTask.dependsOn javaTask
+ cleanupTask.mustRunAfter javaTask
+
+ // Task for running testcases in Python SDK
+ def testOpts = [
+ "--attr=UsesCrossLanguageTransforms"
+ ]
+ def pipelineOpts = [
+ "--runner=PortableRunner",
+ "--experiments=xlang_test",
Review comment:
Why do we need to define a new experiment for a test ? I think we should try
to keep she set of experiments minimum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 243555)
Time Spent: 7.5h (was: 7h 20m)
> Add an integration test suite for cross-language transforms for Flink runner
> ----------------------------------------------------------------------------
>
> Key: BEAM-6683
> URL: https://issues.apache.org/jira/browse/BEAM-6683
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Chamikara Jayalath
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> We should add an integration test suite that covers following.
> (1) Currently available Java IO connectors that do not use UDFs work for
> Python SDK on Flink runner.
> (2) Currently available Python IO connectors that do not use UDFs work for
> Java SDK on Flink runner.
> (3) Currently available Java/Python pipelines work in a scalable manner for
> cross-language pipelines (for example, try 10GB, 100GB input for
> textio/avroio for Java and Python).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
