[
https://issues.apache.org/jira/browse/BEAM-5995?focusedWorklogId=246130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246130
]
ASF GitHub Bot logged work on BEAM-5995:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/19 15:34
Start Date: 21/May/19 15:34
Worklog Time Spent: 10m
Work Description: kkucharc commented on pull request #8151: [BEAM-5995]
add Jenkins job with GBK Python load tests
URL: https://github.com/apache/beam/pull/8151#discussion_r286091546
##########
File path: sdks/python/apache_beam/testing/load_tests/build.gradle
##########
@@ -29,18 +29,20 @@ def loadTestArgsProperty = "loadTest.args"
def runnerProperty = "runner"
-task run(type: Exec) {
- dependsOn 'setupVirtualenv'
- dependsOn 'installGcpTest'
-
+task run(type: Exec, dependsOn: installGcpTest) {
def loadTestArgs = project.findProperty(loadTestArgsProperty) ?: ""
def runnerArg = project.findProperty(runnerProperty) ?: ""
if (runnerArg == 'DataflowRunner' || runnerArg == 'TestDataflowRunner') {
- dependsOn 'sdist'
- loadTestArgs +=" --sdk_location=${project.buildDir}/apache-beam.tar.gz"
+ def sdistPath =
"${project.rootDir}/sdks/python/apache_beam/testing/load_tests/build/apache-beam.tar.gz"
Review comment:
Well, this is caused by recent changes in `BeamModulePlugin` - `sdist` task
has `dist-dir` pointed to `project.buildDir`. Because load-tests gradle file is
located in load tests dir, the buildDir is location of load tests. So it
creates package there.
Well, one of suggestion in past was to move this task to other tasks in main
`build.gradle`. But I postponed decision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 246130)
Time Spent: 40h 50m (was: 40h 40m)
> Create Jenkins jobs to run the load tests
> -----------------------------------------
>
> Key: BEAM-5995
> URL: https://issues.apache.org/jira/browse/BEAM-5995
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 40h 50m
> Remaining Estimate: 0h
>
> (/) Add SMOKE test
> Add GBK load tests.
> Add CoGBK load tests.
> Add Pardo load tests.
> Add SideInput tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
