[ https://issues.apache.org/jira/browse/BEAM-6693?focusedWorklogId=247814&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247814 ]
ASF GitHub Bot logged work on BEAM-6693: ---------------------------------------- Author: ASF GitHub Bot Created on: 24/May/19 01:20 Start Date: 24/May/19 01:20 Worklog Time Spent: 10m Work Description: robinyqiu commented on issue #8535: [BEAM-6693] ApproximateUnique transform for Python SDK URL: https://github.com/apache/beam/pull/8535#issuecomment-495438775 Thanks for the changes. I left a few comments. A quick reminder: after you have addressed all reviewers' comments, you can squash all the commits into one (see https://stackoverflow.com/a/5189600/9963322). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 247814) Time Spent: 10h (was: 9h 50m) > ApproximateUnique transform for Python SDK > ------------------------------------------ > > Key: BEAM-6693 > URL: https://issues.apache.org/jira/browse/BEAM-6693 > Project: Beam > Issue Type: New Feature > Components: sdk-py-core > Reporter: Ahmet Altay > Assignee: Hannah Jiang > Priority: Minor > Time Spent: 10h > Remaining Estimate: 0h > > Add a PTransform for estimating the number of distinct elements in a > PCollection and the number of distinct values associated with each key in a > PCollection KVs. > it should offer the same API as its Java counterpart: > https://github.com/apache/beam/blob/11a977b8b26eff2274d706541127c19dc93131a2/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)