[
https://issues.apache.org/jira/browse/BEAM-6623?focusedWorklogId=249145&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249145
]
ASF GitHub Bot logged work on BEAM-6623:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 05:53
Start Date: 28/May/19 05:53
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8622: [BEAM-6623]
add DataflowValidatesRunner batch tests for python 3.6 an…
URL: https://github.com/apache/beam/pull/8622#discussion_r287938326
##########
File path: sdks/python/test-suites/dataflow/py37/build.gradle
##########
@@ -69,3 +69,23 @@ task validatesRunnerBatchTests(dependsOn:
['installGcpTest', 'sdist']) {
}
}
}
+
+task validatesRunnerStreamingTests(dependsOn: ['installGcpTest', 'sdist']) {
+ dependsOn ":runners:google-cloud-dataflow-java:worker:shadowJar"
+
+ def dataflowWorkerJar =
project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath
+
+ doLast {
+ // TODO(BEAM-3544,BEAM-5025): Disable tests with 'sickbay-streaming' tag.
+ def testOpts = basicTestOpts +
["--attr=ValidatesRunner,!sickbay-streaming"]
+ def argMap = ["test_opts": testOpts,
+ "streaming": "true",
+ "sdk_location": "${project.buildDir}/apache-beam.tar.gz",
+ "worker_jar": dataflowWorkerJar]
+ def cmdArgs = project.mapToArgString(argMap)
+ exec {
+ executable 'sh'
+ args '-c', ". ${project.ext.envdir}/bin/activate &&
${runScriptsDir}/run_integration_test.sh $cmdArgs"
+ }
+ }
+}
Review comment:
Let's add the end-of-line as in other files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 249145)
Time Spent: 6h 10m (was: 6h)
> Dataflow ValidatesRunner test suite should also exercise ValidatesRunner
> tests under Python 3.
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-6623
> URL: https://issues.apache.org/jira/browse/BEAM-6623
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Frederik Bode
> Priority: Blocker
> Fix For: 2.14.0
>
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
