[ https://issues.apache.org/jira/browse/BEAM-6441?focusedWorklogId=256529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256529 ]
ASF GitHub Bot logged work on BEAM-6441: ---------------------------------------- Author: ASF GitHub Bot Created on: 09/Jun/19 18:26 Start Date: 09/Jun/19 18:26 Worklog Time Spent: 10m Work Description: stale[bot] commented on issue #8223: [BEAM-6441] Revise release branch cut instructions URL: https://github.com/apache/beam/pull/8223#issuecomment-500234400 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the d...@beam.apache.org list. Thank you for your contributions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 256529) Time Spent: 2h (was: 1h 50m) > cut_release_branch.sh should not push to master without verification and a PR > ----------------------------------------------------------------------------- > > Key: BEAM-6441 > URL: https://issues.apache.org/jira/browse/BEAM-6441 > Project: Beam > Issue Type: Bug > Components: build-system > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Currently, the cut_release_branch.sh does many things: > - Edits files in place to update the version > - Makes a local commit > - Pushing the local commit to master > - Creates a new branch > - Edits files in place to update the version > - Pushes the release branch > I think all of this except the push to master are OK. It is possible that we > have something - website, examples, new places where the version is > hardcoded, etc, that get broken in this process. Moving from x-SNAPSHOT to > (x+1)-SNAPSHOT is easy to do in a pull request and safe. The release branch > creation does not need to be synchronized with this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)