[
https://issues.apache.org/jira/browse/BEAM-7536?focusedWorklogId=258610&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258610
]
ASF GitHub Bot logged work on BEAM-7536:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/19 11:02
Start Date: 12/Jun/19 11:02
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #8834: [BEAM-7536]
Fix BigQuery dataset name in collecting Load Tests metrics
URL: https://github.com/apache/beam/pull/8834#discussion_r292853472
##########
File path: .test-infra/jenkins/LoadTestsBuilder.groovy
##########
@@ -79,6 +79,14 @@ class LoadTestsBuilder {
return baseName
}
}
+
+ private static String getContextualDatasetKey(SDK sdk) {
+ String datasetKey = 'bigQueryDataset'
+ if (sdk == SDK.PYTHON) {
+ datasetKey = 'metrics_dataset'
Review comment:
Why the name `metrics_dataset`? Why is it different than the one in Java sdk
(I don't mean only the snake_case convention)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 258610)
Time Spent: 40m (was: 0.5h)
> Fix BigQuery dataset name in collecting Load Tests metrics
> ----------------------------------------------------------
>
> Key: BEAM-7536
> URL: https://issues.apache.org/jira/browse/BEAM-7536
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Dataset should have __PR_ suffix __ in case of phrase triggered load tests
> and no suffix in Cron tasks. It requires fix in case of Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
