[ 
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=259140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259140
 ]

ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jun/19 22:51
            Start Date: 12/Jun/19 22:51
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on issue #7805: [BEAM-3061] Done 
notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#issuecomment-501482933
 
 
   Yeah, which also means that that the solution which does not output anything 
will not work for streaming mode. I think it'll be good to output some 
information about batches of mutations that were written for a given 
bundle+window combination instead of not outputting anything or outputting just 
null. 
   
   How about just updating this recordsWritten counter to be per window and 
outputting that ?
   
https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java#L702
   
   Another option might be to output failed records. But this should be 
optional since if everything get written to BigTable without errors, nothing 
will get output from the write step.
   
   BTW it might be worth summarizing this discussion in the dev list.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 259140)
    Time Spent: 6h  (was: 5h 50m)

> BigtableIO should support emitting a sentinel "done" value when a bundle 
> completes
> ----------------------------------------------------------------------------------
>
>                 Key: BEAM-3061
>                 URL: https://issues.apache.org/jira/browse/BEAM-3061
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Steve Niemitz
>            Assignee: Steve Niemitz
>            Priority: Major
>          Time Spent: 6h
>  Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1].  This 
> approach was taken based on discussion there.
> [1] 
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to