[ 
https://issues.apache.org/jira/browse/BEAM-7018?focusedWorklogId=260436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260436
 ]

ASF GitHub Bot logged work on BEAM-7018:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/19 13:59
            Start Date: 14/Jun/19 13:59
    Worklog Time Spent: 10m 
      Work Description: mszb commented on issue #8859: [BEAM-7018] Added Regex 
transform for PythonSDK
URL: https://github.com/apache/beam/pull/8859#issuecomment-502120219
 
 
   Hi @robertwb. Thanks for review PR and for your suggestions. I believe 
making the separate the regex module is not what something I've seen in the py 
sdk. Because other modules (ex: Reify) is also available as a utility in py 
sdk. Moreover, regex transform is not something I think can be called as a 
module, so my thoughts util.py is a good place for these kinds of transforms 
   
   And for the other part, I think you are right, using lambda will definitely 
improve the code in terms of readability.
   let me make some changes.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 260436)
    Time Spent: 0.5h  (was: 20m)

> Regex transform for Python SDK
> ------------------------------
>
>                 Key: BEAM-7018
>                 URL: https://issues.apache.org/jira/browse/BEAM-7018
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Rose Nguyen
>            Assignee: Shehzaad Nakhoda
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> PTransorms to use Regular Expressions to process elements in a PCollection
> It should offer the same API as its Java counterpart: 
> [https://github.com/apache/beam/blob/11a977b8b26eff2274d706541127c19dc93131a2/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Regex.java]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to