[
https://issues.apache.org/jira/browse/BEAM-7499?focusedWorklogId=260731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260731
]
ASF GitHub Bot logged work on BEAM-7499:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/19 21:37
Start Date: 14/Jun/19 21:37
Worklog Time Spent: 10m
Work Description: ttanay commented on pull request #8866: [BEAM-7499]
unskip ReifyTest.test_window
URL: https://github.com/apache/beam/pull/8866
Unskip to test if ReifyTest.test_window works as intended.
This is related to
[BEAM-7499](https://issues.apache.org/jira/browse/BEAM-7499)
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 260731)
Time Spent: 1h (was: 50m)
> ReifyTest.test_window fails in DirectRunner due to 'assign_context.window
> should not be None.'
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-7499
> URL: https://issues.apache.org/jira/browse/BEAM-7499
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core, test-failures
> Reporter: Luke Cwik
> Assignee: Pablo Estrada
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
>
> [PR 8717|https://github.com/apache/beam/pull/8717] added
> ReifyWindow.test_window which fails on the DirectRunner.
> {code:java}
> ERROR:root:Exception at bundle
> <apache_beam.runners.direct.bundle_factory._Bundle object at 0x7f087ab31248>,
> due to an exception.
> Traceback (most recent call last):
> File "apache_beam/runners/direct/executor.py", line 343, in call
> finish_state)
> File "apache_beam/runners/direct/executor.py", line 380, in attempt_call
> evaluator.process_element(value)
> File "apache_beam/runners/direct/transform_evaluator.py", line 636, in
> process_element
> self.runner.process(element)
> File "apache_beam/runners/common.py", line 780, in
> apache_beam.runners.common.DoFnRunner.process
> def process(self, windowed_value):
> File "apache_beam/runners/common.py", line 784, in
> apache_beam.runners.common.DoFnRunner.process
> self._reraise_augmented(exn)
> File "apache_beam/runners/common.py", line 851, in
> apache_beam.runners.common.DoFnRunner._reraise_augmented
> raise_with_traceback(new_exn)
> File "apache_beam/runners/common.py", line 782, in
> apache_beam.runners.common.DoFnRunner.process
> return self.do_fn_invoker.invoke_process(windowed_value)
> File "apache_beam/runners/common.py", line 453, in
> apache_beam.runners.common.SimpleInvoker.invoke_process
> output_processor.process_outputs(
> File "apache_beam/runners/common.py", line 915, in
> apache_beam.runners.common._OutputProcessor.process_outputs
> self.window_fn.assign(assign_context))
> File "apache_beam/transforms/util.py", line 557, in assign
> 'assign_context.window should not be None. '
> ValueError: assign_context.window should not be None. This might be due to a
> DoFn returning a TimestampedValue. [while running 'add_timestamps2']
> Traceback (most recent call last):
> File "apache_beam/transforms/util_test.py", line 501, in test_window
> assert_that(reified_pc, equal_to(expected), reify_windows=True)
> File "apache_beam/pipeline.py", line 426, in __exit__
> self.run().wait_until_finish()
> File "apache_beam/testing/test_pipeline.py", line 109, in run
> state = result.wait_until_finish()
> File "apache_beam/runners/direct/direct_runner.py", line 430, in
> wait_until_finish
> self._executor.await_completion()
> File "apache_beam/runners/direct/executor.py", line 400, in await_completion
> self._executor.await_completion()
> File "apache_beam/runners/direct/executor.py", line 446, in await_completion
> raise_(t, v, tb)
> File "apache_beam/runners/direct/executor.py", line 343, in call
> finish_state)
> File "apache_beam/runners/direct/executor.py", line 380, in attempt_call
> evaluator.process_element(value)
> File "apache_beam/runners/direct/transform_evaluator.py", line 636, in
> process_element
> self.runner.process(element)
> File "apache_beam/runners/common.py", line 780, in
> apache_beam.runners.common.DoFnRunner.process
> def process(self, windowed_value):
> File "apache_beam/runners/common.py", line 784, in
> apache_beam.runners.common.DoFnRunner.process
> self._reraise_augmented(exn)
> File "apache_beam/runners/common.py", line 851, in
> apache_beam.runners.common.DoFnRunner._reraise_augmented
> raise_with_traceback(new_exn)
> File "apache_beam/runners/common.py", line 782, in
> apache_beam.runners.common.DoFnRunner.process
> return self.do_fn_invoker.invoke_process(windowed_value)
> File "apache_beam/runners/common.py", line 454, in
> apache_beam.runners.common.SimpleInvoker.invoke_process
> windowed_value, self.process_method(windowed_value.value))
> File "apache_beam/transforms/core.py", line 1292, in <lambda>
> wrapper = lambda x: [fn(x)]
> File "apache_beam/testing/util.py", line 129, in _equal
> 'Failed assert: %r == %r' % (sorted_expected, sorted_actual))
> BeamAssertException: Failed assert: [TestWindowedValue(value=('a', 100,
> GlobalWindow), timestamp=100, windows=[GlobalWindow]),
> TestWindowedValue(value=('b', 200, GlobalWindow), timestamp=200,
> windows=[GlobalWindow]), TestWindowedValue(value=('c', 300, GlobalWindow),
> timestamp=300, windows=[GlobalWindow])] == [TestWindowedValue(value=(('a',
> 100.0, (GlobalWindow,), PaneInfo(first: True, last: True, timing: 3, index:
> 0, nonspeculative_index: 0)), Timestamp(-9223372036854.775000),
> GlobalWindow), timestamp=Timestamp(-9223372036854.775000),
> windows=[GlobalWindow]), TestWindowedValue(value=(('c', 300.0,
> (GlobalWindow,), PaneInfo(first: True, last: True, timing: 3, index: 0,
> nonspeculative_index: 0)), Timestamp(-9223372036854.775000), GlobalWindow),
> timestamp=Timestamp(-9223372036854.775000), windows=[GlobalWindow]),
> TestWindowedValue(value=(('b', 200.0, (GlobalWindow,), PaneInfo(first: True,
> last: True, timing: 3, index: 0, nonspeculative_index: 0)),
> Timestamp(-9223372036854.775000), GlobalWindow),
> timestamp=Timestamp(-9223372036854.775000), windows=[GlobalWindow])] [while
> running 'assert_that/Match']
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
