[
https://issues.apache.org/jira/browse/BEAM-7455?focusedWorklogId=261949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261949
]
ASF GitHub Bot logged work on BEAM-7455:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/19 01:24
Start Date: 18/Jun/19 01:24
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8818: [BEAM-7455]
Improve Avro IO integration test coverage on Python 3.
URL: https://github.com/apache/beam/pull/8818#discussion_r294578076
##########
File path: sdks/python/apache_beam/io/avroio_it_test.py
##########
@@ -0,0 +1,236 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""End-to-end test for Avro IO's.
+
+Writes a configurable number of records to a temporary location with each of
+{avro,fastavro}, then reads them back in, joins the two read datasets, and
Review comment:
Please update the test docstring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 261949)
Time Spent: 1h 40m (was: 1.5h)
> Improve Avro IO integration test coverage on Python 3.
> ------------------------------------------------------
>
> Key: BEAM-7455
> URL: https://issues.apache.org/jira/browse/BEAM-7455
> Project: Beam
> Issue Type: Sub-task
> Components: io-python-avro
> Reporter: Valentyn Tymofieiev
> Assignee: Frederik Bode
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It seems that we don't have an integration test for Avro IO on Python 3:
> fastavro_it_test [1] depends on both avro and fastavro, however avro package
> currently does not work with Beam on Python 3, so we don't have an
> integration test that exercises Avro IO on Python 3.
> We should add an integration test for Avro IO that does not need both
> libraries at the same time, and instead can run using either library.
> [~frederik] is this something you could help with?
> cc: [~chamikara] [~Juta]
> [1]
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/fastavro_it_test.py
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
