[
https://issues.apache.org/jira/browse/BEAM-7579?focusedWorklogId=262069&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262069
]
ASF GitHub Bot logged work on BEAM-7579:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/19 06:12
Start Date: 18/Jun/19 06:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8883: [BEAM-7579]
Use bucket with default key in ITs
URL: https://github.com/apache/beam/pull/8883#discussion_r294622993
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipelineOptions.java
##########
@@ -36,6 +36,14 @@
void setTempRoot(String value);
+ /**
+ * An alternative tempRoot that has a bucket-default KMS key set. Used for
GCP CMEK integration
+ * tests.
+ */
+ String getTempRootKms();
Review comment:
We shouldn't define this here since this is really specific to GCP.
Two ways you could solve this:
* You can create an interface called GcpTestPipelineOptions within the gcp
extensions package and make sure it gets registered with a
PipelineOptionsRegistrar.
* Continue to use tempRoot but make sure the that CMEK related ITs are a
different gradle test task (with a CMEK appropriate temp root defined) which
filters which tests it runs to only the CMEK ones that need a different temp
root while those ITs are excluded from any other IT suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 262069)
Time Spent: 40m (was: 0.5h)
> Tests fail with "Cannot create a default bucket when --dataflowKmsKey is set."
> ------------------------------------------------------------------------------
>
> Key: BEAM-7579
> URL: https://issues.apache.org/jira/browse/BEAM-7579
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.13.0
> Reporter: Luke Cwik
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Example run: https://builds.apache.org/job/beam_PostCommit_Java/3535/
> Failing tests:
> {code:java}
> org.apache.beam.sdk.io.gcp.storage.GcsKmsKeyIT.testGcsWriteWithKmsKey
> org.apache.beam.sdk.io.gcp.storage.GcsKmsKeyIT.testGcsWriteWithKmsKey
> org.apache.beam.sdk.extensions.gcp.util.GcsUtilIT.testRewriteMultiPart
> {code}
> Example trace:
> {code:java}
> Error Message
> java.lang.IllegalArgumentException: Cannot create a default bucket when
> --dataflowKmsKey is set.
> Stacktrace
> java.lang.IllegalArgumentException: Cannot create a default bucket when
> --dataflowKmsKey is set.
> at
> org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122)
> at
> org.apache.beam.sdk.extensions.gcp.options.GcpOptions$GcpTempLocationFactory.tryCreateDefaultBucket(GcpOptions.java:297)
> at
> org.apache.beam.sdk.extensions.gcp.options.GcpOptions$GcpTempLocationFactory.create(GcpOptions.java:268)
> at
> org.apache.beam.sdk.extensions.gcp.options.GcpOptions$GcpTempLocationFactory.create(GcpOptions.java:256)
> at
> org.apache.beam.sdk.options.ProxyInvocationHandler.returnDefaultHelper(ProxyInvocationHandler.java:592)
> at
> org.apache.beam.sdk.options.ProxyInvocationHandler.getDefault(ProxyInvocationHandler.java:533)
> at
> org.apache.beam.sdk.options.ProxyInvocationHandler.invoke(ProxyInvocationHandler.java:158)
> at com.sun.proxy.$Proxy32.getGcpTempLocation(Unknown Source)
> at
> org.apache.beam.sdk.io.gcp.storage.GcsKmsKeyIT.testGcsWriteWithKmsKey(GcsKmsKeyIT.java:79)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
