[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=262789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262789
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/19 05:36
Start Date: 19/Jun/19 05:36
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #8769: [WIP]
[BEAM-3645] support multi processes for Python FnApiRunner with
EmbeddedGrpcWorkerHandler
URL: https://github.com/apache/beam/pull/8769#discussion_r295126791
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1418,6 +1449,51 @@ def process_bundle(self, inputs, expected_outputs,
parallel_uid_counter=None):
return result, split_results
+class ParallelBundleManager(BundleManager):
+ _uid_counter = 0
+ def process_bundle(self, inputs, expected_outputs):
+ input_value = list(inputs.values())[0]
Review comment:
Today I found a case where we shouldn't split inputs, which is a transform
with timer and when use grpc handler. I would like to get your advice how to
know when we should split inputs and when we shouldn't. I added a comment with
examples at the new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 262789)
Time Spent: 5h 40m (was: 5.5h)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
