[
https://issues.apache.org/jira/browse/BEAM-6955?focusedWorklogId=263346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-263346
]
ASF GitHub Bot logged work on BEAM-6955:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/19 21:32
Start Date: 19/Jun/19 21:32
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #8189: [BEAM-6955] Support
Dataflow --sdk_location with modified version number
URL: https://github.com/apache/beam/pull/8189#issuecomment-503754897
@dlesco, we can close this in favor of #8885.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 263346)
Time Spent: 2h 20m (was: 2h 10m)
> Support Dataflow --sdk_location with modified version number
> ------------------------------------------------------------
>
> Key: BEAM-6955
> URL: https://issues.apache.org/jira/browse/BEAM-6955
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.11.0
> Reporter: Daniel Lescohier
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Fix For: 2.14.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Support Dataflow --sdk_location with modified version number
> Determine the version tag to use for the Google Container Registry, for the
> service image versions to use on the Dataflow worker nodes. Users of Dataflow
> may be using a locally-modified version of Apache Beam, which they submit to
> Dataflow with the --sdk_location option. Those users would most likely modify
> the version number of Apache Beam, so they can distinguish it from the public
> distribution of Apache Beam. However, the remote nodes in Dataflow still need
> to bootsrap the worker service with a Docker image that a version tag exists
> for.
> The most appropriate way for system integrators to modify the Apache Beam
> version number would be to add a Local Version Identifier:
> https://www.python.org/dev/peps/pep-0440/#local-version-identifiers
> If people only use Local Version Identifiers, then we could use the "public"
> attribute of the pkg_resources version object.
> If people instead use a post-release version identifier:
> https://www.python.org/dev/peps/pep-0440/#post-releases then only the
> "base_version" attribute would work both of these version number changes.
> Since Dataflow documentation does not specify how to modify version numbers,
> I am choosing to use "base_version" attribute.
> Will shortly submit a PR with the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
