[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=264152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264152
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/19 21:37
Start Date: 20/Jun/19 21:37
Worklog Time Spent: 10m
Work Description: jkff commented on pull request #7805: [BEAM-3061] Done
notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#discussion_r296023592
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##########
@@ -661,11 +664,11 @@ Write withBigtableService(BigtableService
bigtableService) {
}
@Override
- public PDone expand(PCollection<KV<ByteString, Iterable<Mutation>>> input)
{
+ public PCollection<BigtableWriteResult> expand(
Review comment:
I think you don't necessarily need to copy all the options. You'd only need
that if you want to support code like
"BigTableIO.write().withWriteResults().withTable()..and so on", but if you're
ok with allowing .withWriteResults() only in the last position on the builder,
then you can just capture the whole original Write object, and the object
returned by withWriteResults() doesn't need any more setters of its own. It's
still a bit of refactoring, but not as much boilerplate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 264152)
Time Spent: 11h (was: 10h 50m)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 11h
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
