[ 
https://issues.apache.org/jira/browse/BEAM-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872717#comment-16872717
 ] 

Valentyn Tymofieiev commented on BEAM-7284:
-------------------------------------------

[~yoshiki.obata], This could definitely be a fix, thanks a lot for exploring. I 
don't yet fully understand what else may be impacted by this change, and 
whether there may be unintended side-effects. It would be great if you could 
clarify it here and/or in the PR description.

Also, it would be great to to add a unit test for Dataclasses to see that they 
are indeed supported. Since Dataclasses will be considered invalid syntax on 
Python 2, we may have to temporary wrap incompatible code with eval() 
statements, as was done in 
https://github.com/apache/beam/pull/8893#discussion_r295534911.

> Support Py3 Dataclasses 
> ------------------------
>
>                 Key: BEAM-7284
>                 URL: https://issues.apache.org/jira/browse/BEAM-7284
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Priority: Major
>
> It looks like dill does not support Dataclasses yet, 
> https://github.com/uqfoundation/dill/issues/312, which very likely means that 
> Beam does not support them either.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to