[
https://issues.apache.org/jira/browse/BEAM-7536?focusedWorklogId=270751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270751
]
ASF GitHub Bot logged work on BEAM-7536:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/19 09:36
Start Date: 02/Jul/19 09:36
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #8834: [BEAM-7536]
Fix BigQuery dataset name in collecting Load Tests metrics
URL: https://github.com/apache/beam/pull/8834#discussion_r299392788
##########
File path: .test-infra/jenkins/LoadTestsBuilder.groovy
##########
@@ -56,6 +49,14 @@ class LoadTestsBuilder {
}
}
+ static String setBQDatasetNameByTriggerContext(String baseName,
TriggeringContext triggeringContext) {
Review comment:
Ok. I've seen it. I don't want to bikeshed about it much but just to
explain:
- we're not setting anything. It's a static method that lets us get the
name given the right context and base name. So set can be misguiding.
- the method arguments already tell us what is being used to determine what
the name should be (`baseName`, `triggeringContext`). Mentioning them (the
context) in the name too is a noise IMO and should be avoided.
This is why I suggested this. Let me know if you agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 270751)
Time Spent: 11h 10m (was: 11h)
> Fix BigQuery dataset name in collecting Load Tests metrics
> ----------------------------------------------------------
>
> Key: BEAM-7536
> URL: https://issues.apache.org/jira/browse/BEAM-7536
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> Dataset should have __PR_ suffix __ in case of phrase triggered load tests
> and no suffix in Cron tasks. It requires fix in case of Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
