[
https://issues.apache.org/jira/browse/BEAM-6480?focusedWorklogId=273928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273928
]
ASF GitHub Bot logged work on BEAM-6480:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 09:18
Start Date: 09/Jul/19 09:18
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9005:
[BEAM-6480] Adds AvroIO sink for generic records.
URL: https://github.com/apache/beam/pull/9005#discussion_r301481549
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
##########
@@ -1703,6 +1704,28 @@ public void populateDisplayData(DisplayData.Builder
builder) {
.build();
}
+ /**
+ * A {@link Sink} for use with {@link FileIO#write} and {@link
FileIO#writeDynamic}, writing
+ * elements with a given (common) schema, like {@link
#writeGenericRecords(Schema)}.
+ */
+ @Experimental
+ public static <ElementT extends IndexedRecord> Sink<ElementT>
sinkWithSchema(Schema schema) {
Review comment:
What is a point to name this method and `sinkWithSchema(String schema)`
below differently and not just overload already existing `sink()`? Not a big
deal but imho it could be a bit confusing for users since, anyway, the schema
is used by current sink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 273928)
Time Spent: 2h 40m (was: 2.5h)
> Add AvroIO.sink for IndexedRecord (FileIO compatible)
> -----------------------------------------------------
>
> Key: BEAM-6480
> URL: https://issues.apache.org/jira/browse/BEAM-6480
> Project: Beam
> Issue Type: New Feature
> Components: io-java-avro
> Affects Versions: 2.9.0
> Reporter: Romain Manni-Bucau
> Assignee: Ryan Skraba
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> More generally for sink there is no need to create a mapper API since the
> previous PTransform can always map in a format the sink support so any sink
> can assume the format is right.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
