[
https://issues.apache.org/jira/browse/BEAM-7719?focusedWorklogId=275088&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-275088
]
ASF GitHub Bot logged work on BEAM-7719:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/19 22:14
Start Date: 10/Jul/19 22:14
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9036: [BEAM-7719]
Ensure that publishing vendored artifacts checks the contents of the jar before
publishing.
URL: https://github.com/apache/beam/pull/9036#discussion_r302294380
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/VendorJavaPlugin.groovy
##########
@@ -146,6 +146,8 @@ artifactId=${project.name}
// Only publish vendored dependencies if specifically requested.
if (project.hasProperty("vendoredDependenciesOnly")) {
project.apply plugin: 'maven-publish'
+ // Ensure that we validate the contents of the jar before publishing
+ project.publish.dependsOn project.check
Review comment:
This will only run `check` on Java gradle projects, not the root project
(which include Python, Go, etc.), right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 275088)
Time Spent: 40m (was: 0.5h)
> Ensure that publishing vendored artifacts first validates there contents
> ------------------------------------------------------------------------
>
> Key: BEAM-7719
> URL: https://issues.apache.org/jira/browse/BEAM-7719
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> During the release of vendored guava 26.0, it was discovered that we don't
> check the contents of the jars automatically.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
