[
https://issues.apache.org/jira/browse/BEAM-7060?focusedWorklogId=280249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280249
]
ASF GitHub Bot logged work on BEAM-7060:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/19 07:17
Start Date: 22/Jul/19 07:17
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9109: [BEAM-7060]
Migrate to native typing types where possible.
URL: https://github.com/apache/beam/pull/9109#discussion_r305701083
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -669,7 +669,7 @@ def start_bundle(self):
assert len(self._outputs) == 1
self.output_pcollection = list(self._outputs)[0]
- # The output type of a GroupByKey will be KV[Any, Any] or more specific.
Review comment:
KV is literally just an alias for Tuple, probably not worth its weight to
keep outside of the Typing module. WindowedValue should be doable as a Generic
type, but it's mostly internal, so deciding on it's final state can wait as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 280249)
Time Spent: 2h 50m (was: 2h 40m)
> Design Py3-compatible typehints annotation support in Beam 3.
> -------------------------------------------------------------
>
> Key: BEAM-7060
> URL: https://issues.apache.org/jira/browse/BEAM-7060
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Existing [Typehints implementaiton in
> Beam|[https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/
> ] heavily relies on internal details of CPython implementation, and some of
> the assumptions of this implementation broke as of Python 3.6, see for
> example: https://issues.apache.org/jira/browse/BEAM-6877, which makes
> typehints support unusable on Python 3.6 as of now. [Python 3 Kanban
> Board|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=245&view=detail]
> lists several specific typehints-related breakages, prefixed with "TypeHints
> Py3 Error".
> We need to decide whether to:
> - Deprecate in-house typehints implementation.
> - Continue to support in-house implementation, which at this point is a stale
> code and has other known issues.
> - Attempt to use some off-the-shelf libraries for supporting
> type-annotations, like Pytype, Mypy, PyAnnotate.
> WRT to this decision we also need to plan on immediate next steps to unblock
> adoption of Beam for Python 3.6+ users. One potential option may be to have
> Beam SDK ignore any typehint annotations on Py 3.6+.
> cc: [~udim], [~altay], [~robertwb].
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
