[
https://issues.apache.org/jira/browse/BEAM-6783?focusedWorklogId=280640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280640
]
ASF GitHub Bot logged work on BEAM-6783:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/19 21:08
Start Date: 22/Jul/19 21:08
Worklog Time Spent: 10m
Work Description: kanterov commented on pull request #9119: [BEAM-6783]
byte[] breaks in BeamSQL codegen
URL: https://github.com/apache/beam/pull/9119#discussion_r306033503
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -411,6 +414,8 @@ public Expression field(BlockBuilder list, int index, Type
storageType) {
Expressions.equal(field, Expressions.constant(null)),
Expressions.constant(null),
Expressions.call(WrappedList.class, "of", field));
+ } else if (fromType.getTypeName() == TypeName.BYTES && storageType ==
ByteString.class) {
Review comment:
Had to add "storageType == ByteString.class", "InputGetterImpl" is used to
convert Beam schema types to UDF parameters, that we don't always want for our
own UDFs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 280640)
Time Spent: 1h 10m (was: 1h)
> byte[] breaks in BeamSQL codegen
> --------------------------------
>
> Key: BEAM-6783
> URL: https://issues.apache.org/jira/browse/BEAM-6783
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Gleb Kanterov
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Calcite will call `byte[].toString` because BeamSQL codegen read byte[] from
> Row to calcite (see:
> https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java#L334).
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
